fheroes2
fheroes2 copied to clipboard
ihhub
Realign small monster sprites in battle results
Preliminary checks
- [X] I've checked that there aren't other open issues on the same topic.
- [X] I've checked that this issue is reproducible on the latest snapshot build.
Platform
Other
Describe the bug
This is a good first issue.
The sprites for the Defender and Attacker lines of battle casualties in battle results window need to be realigned, mostly further down. Right now the mohawk of the titans overlap with the "Defender" text when there's a single stack of them.
Save file
Just create a map with an army of lots of titans on a hero.
Additional info
No response
Hello @zenseii,
It seems that you have found time to report some bugs. :) This one has been on my list for a long time. I have not yet taken the time to look into reorganizing this window. Also, it might be necessary to increase the vertical size of this window (depending on the text to be displayed), which the developers are quite reluctant to do at the moment. :rofl:
In fheroes2 (version 0.8):
I had a couple of bugs lying around that I hadn't checked properly how to reproduce and if they'd been reported, and @ihhub gave me the go to post them (not sure he knew how many they might be). Mostly UI stuff, though while reproducing the bugs I ended up finding some others I posted.
Anyhow. I'm not sure this window would need to be any bigger? What sort of text are you fancing? Most translations are well within the length of the text here.
@zenseii.
I had a couple of bugs lying around that I hadn't checked properly if and if they'd been reported, and @ihhub gave me the go to post them (not sure he knew how many they might be). Mostly UI stuff, though while reproducing the bugs I ended up finding some others I posted.
;)
Anyhow. I'm not sure this window would need to be any bigger? What sort of text are you fancing? Most translations are well within the length of the text here.
My concern was in the case of a longer hero name, but that seems fine.
In fheroes2:
Edit:
There would also be the addition of buttons and text that may require the vertical enlargement of the window (https://github.com/ihhub/fheroes2/discussions/5266). That's why I hadn't revised this window yet. :) But this can be done in several independent PRs preferably.