fheroes2 icon indicating copy to clipboard operation
fheroes2 copied to clipboard

Add a separate highscore for multiplayer

Open Branikolog opened this issue 3 years ago • 10 comments

Preliminary checks

Platform

Windows

Describe the bug

Win multiplayer game by eliminating red player: image After that we watch victory animation with dragon and then return to main menu.

Save file

Multiplayer score.zip

Additional info

No response

Branikolog avatar Oct 22 '21 13:10 Branikolog

Hi @Branikolog , does the original game have High Scores for multiplayer mode?

ihhub avatar Oct 24 '21 06:10 ihhub

Hi, @ihhub It actually is.

Branikolog avatar Oct 24 '21 13:10 Branikolog

High scores for multiplayer have been implemented as of this PR I believe: https://github.com/ihhub/fheroes2/pull/4261

Currently the same high score for single and multiplayer matches is shared, and this is how it works in the OG too.

This issue should be closed, @ihhub ?

zenseii avatar Sep 17 '22 21:09 zenseii

I'm marking this as improvement since currently fheroes2 works exactly like the original game, and also any extension of this multiplayer high score functionality shouldn't need to be prioritized as long as network multiplayer isn't implemented in my opinion.

zenseii avatar Oct 10 '22 17:10 zenseii

I would also love the scoreboard for multiplayer. I often play hotseat multiplayer over steam's remote gameplay option. There doesn't seem to be any top 10 score listing after the game completes on linux even for 0.9.21.

To play multiplayer on steam, i use a built in steam multiplayer game, like broforce, delete the contents of the steam directory, and add the fheroes2 files, and rename the executable to broforce. Works like a charm.

denierlexiese avatar Nov 21 '22 16:11 denierlexiese

Hi @denierlexiese.

Do you have this problem when playing a single player map too? I tested a multiplayer hot seat map not too long ago with 2 players and I was able to end up on the high score because my score was high enough. Maybe you're not getting a high enough score to get to the high score?

Right now we have an issue about not telling the player the score if they don't have enough points to achieve a place in the high scores so this might be confusing: https://github.com/ihhub/fheroes2/issues/2918

I suggest we change the title of this issue to better reflect it.

zenseii avatar Nov 21 '22 16:11 zenseii

@zenseii just tried hodge-podge single player. Easily got black dragon score on Impossible - entered high score - showed up in high score gui. Played multiplayer hotseat - expert level 2 player - on ubuntu - finished in 16 days. No score - no ranking. I would imagine it would have at least beat the lowest score of 70.

Either way, both single player and hotseat didn't show the visual score on the dragon breath fmv. Is there a debug running score showed somewhere else in the game while in game? I thought you guys used to show a running totalunder the 'info' gui in a prior version.

denierlexiese avatar Nov 23 '22 19:11 denierlexiese

@denierlexiese Yes, we used to show this before but we removed it since it didn't fit very nicely into the GUI. Hopefully we will be able to show the score for the next upcoming release.

I know for a fact that I tested high scores working for multiplayer some time back and it worked so I'll have to retest it just to confirm your findings. This might be a regression from somewhere then.

The easiest way to test is probably to play the official map named Slugfest and set all players to human and remove all the other players' troops and heroes.

zenseii avatar Nov 23 '22 19:11 zenseii

"The easiest way to test is probably to play the official map named Slugfest and set all players to human and remove all the other players troops and heroes"

@zenseii Just tried that test. Yes on impossible took like 4 days. No high score screen in hot seat multiplayer in UBUNTU.

denierlexiese avatar Nov 23 '22 20:11 denierlexiese

Just tried with new version 1.0, and still an issue in both windows and ubuntu. Appreciate all the work you all do. Multiplayer Hot seat high scores would be great. Running real time score total in any sub menu would be great too.

denierlexiese avatar Dec 23 '22 18:12 denierlexiese

Small bump. It would mean a lot to my father and I, and only because it was reported to be working before. If it's not a simple fix to restore it, it is what it is and could be de-prioritized for later.

denierlexiese avatar Feb 16 '23 19:02 denierlexiese

I'm marking this as a bug and regression because currently the highscore for multiplayer doesn't even work, but it used to work. Not sure when that happened.

zenseii avatar Feb 16 '23 19:02 zenseii

I'll look into this issue.

petar-stamenkov avatar Sep 06 '23 12:09 petar-stamenkov