fheroes2
fheroes2 copied to clipboard
ihhub
Castle music doesn't end when leaving castle screen on Arrax the Jerk
Preliminary checks
- [X] I've checked that there aren't other open issues on the same topic.
- [X] I've checked that this issue is reproducible on the latest snapshot build.
Platform
macOS
Describe the bug
When playing as blue in Arrax the Jerk, entering the castle starts the castle music playing, but leaving the castle does not end it. Ending the turn ends the music, but the same thing happens next time the castle screen is entered.
Save file
Additional info
No response
Hi @jdm if there is no terrain music for the current terrain (this may happen in MIDI mode for certain terrains), castle music will continue to play. The same happens when you move from a terrain for which there is MIDI music to a terrain which don't have it - old music continues to play. I'm not really sure that we should forcibly stop the music in such cases. The wrong music looks better than no music at all IMHO.
Hello everyone,
I have made a proposal to remedy this here: https://github.com/ihhub/fheroes2/issues/1980.
Reclassifying it as improvement as the original game behave the same due to assets absence.
