fheroes2 icon indicating copy to clipboard operation
fheroes2 copied to clipboard

Highlight Cells refactoring

Open tau3 opened this issue 3 years ago • 4 comments

Hello!

Saw a code smell warning on sonarcloud. Decided to extract Battle::Interface::CalculateHighlightCells and split into smaller members without logic changes. This is only the first iteration, some of resulting members are still bloated and should be refactored, but current changeset is already not so small.

Please, review

tau3 avatar Aug 17 '21 18:08 tau3

maybe all this cursor deciding logic can be moved out to a separate class because Interface already has to much members and functions

tau3 avatar Aug 17 '21 18:08 tau3

Hi @tau3 , could you please solve merge conflict in this pull request?

ihhub avatar Aug 22 '21 03:08 ihhub

well, that merge was tough

tau3 avatar Aug 30 '21 22:08 tau3

Hi @tau3 , if we're still going with this change please fix merging conflicts for this pull request.

ihhub avatar Nov 08 '21 14:11 ihhub

I am closing this pull request as @tau3 is not responding and the changes proposed in this pull request are not critical.

@tau3 , if you think that you are able to fix merge conflicts please feel free to reopen this pull request.

ihhub avatar Mar 21 '23 14:03 ihhub