fheroes2
fheroes2 copied to clipboard
Highlight Cells refactoring
Hello!
Saw a code smell warning on sonarcloud. Decided to extract Battle::Interface::CalculateHighlightCells
and split into smaller members without logic changes. This is only the first iteration, some of resulting members are still bloated and should be refactored, but current changeset is already not so small.
Please, review
maybe all this cursor deciding logic can be moved out to a separate class because Interface
already has to much members and functions
Hi @tau3 , could you please solve merge conflict in this pull request?
well, that merge was tough
Hi @tau3 , if we're still going with this change please fix merging conflicts for this pull request.
I am closing this pull request as @tau3 is not responding and the changes proposed in this pull request are not critical.
@tau3 , if you think that you are able to fix merge conflicts please feel free to reopen this pull request.