fheroes2 icon indicating copy to clipboard operation
fheroes2 copied to clipboard

Adventure map, Hero, revealed area

Open LeHerosInconnu opened this issue 4 years ago • 8 comments

In fheroes2, the area revealed by the hero is reduced compared to the original game.

In original game:

Hero revealed area H2 01

In fheroes2:

Magic Garden not captured 01

Similar issue: https://github.com/ihhub/fheroes2/issues/1434.

LeHerosInconnu avatar Nov 01 '20 20:11 LeHerosInconnu

If I understand, it's said in #1434 that it is intentional ?

vincent-grosbois avatar Jan 26 '21 17:01 vincent-grosbois

Hello @vincent-grosbois,

If I understand, it's said in #1434 that it is intentional ?

Yes, this was done intentionally in fheroes2. Here is another case to show that this different mode of operation from the original game causes annoying problems for the player by diminishing the visibility of the original game. :)

LeHerosInconnu avatar Jan 26 '21 17:01 LeHerosInconnu

Ok I see In that case, what do we do with this ? this is marked as 0.9 , but I'm not sure I can do anything for this issue

vincent-grosbois avatar Jan 26 '21 17:01 vincent-grosbois

@vincent-grosbois.

Ok I see In that case, what do we do with this ? this is marked as 0.9 , but I'm not sure I can do anything for this issue

A discussion would be planned for this. For the time being, it would be necessary to know if this is considered urgent. So, @ihhub and @Branikolog is this urgent?

For my part, I vote for an operation as in the original game. Every square that is uncovered counts and this may change the strategy to be adopted. :)

LeHerosInconnu avatar Jan 26 '21 17:01 LeHerosInconnu

Hello, @vincent-grosbois and @LeHerosInconnu ! The nearest release is AI/logic oriented. I believe, we can postpone this issue a little bit, so we can more deeply discuss here the problem and the solition.) But the last word is for @ihhub, surely. :)

On subject: I really don't understand, why do we have such hexagon-like shape of area. Why couldn't we make it more round-shaped? Can we make a compromise solution between these two variants? Just by adding a small revealed area in this places.... 97812963-552a5d80-1c85-11eb-8f98-e2ccf7601a16

Branikolog avatar Jan 26 '21 18:01 Branikolog

Heroes 2 players are used to it working this way:

Hero revealed area H2 01

Why change that? Not to mention all the scenarios created with the game's original mode of operation.

LeHerosInconnu avatar Jan 26 '21 20:01 LeHerosInconnu

Reveal area should be the same as in the original game as it's closer to circle shape and old maps depend on this shape. This is the method void Maps::ClearFog( s32 index, int scoute, int color ) which should be modified.

ihhub avatar Jan 27 '21 03:01 ihhub

Seems like this is already fixed in the latest HEAD:

OG: image

fheroes2: image

a1exsh avatar Oct 03 '21 15:10 a1exsh

@ihhub, as mentioned by @a1exsh, I think we can close this issue.

Unless there is something else to do?

felix642 avatar Oct 16 '22 18:10 felix642

Closing this issue as being fixed.

@felix642 , thank you so spotting this!

ihhub avatar Oct 18 '22 00:10 ihhub