fheroes2 icon indicating copy to clipboard operation
fheroes2 copied to clipboard

Castle construction screen, shadow of the text in the information bar at the bottom of the screen, the shadow of the text should not be displayed over the yellow frame of the info bar

Open LeHerosInconnu opened this issue 4 years ago • 10 comments

In fheroes2, the shadow of the text is displayed over the yellow frame of the info bar. In the original game, this is not the case.

In original game:

Building sign position H2 01

In fheroes2:

Building sign position fh2 01

Similar issues: https://github.com/ihhub/fheroes2/issues/1675, https://github.com/ihhub/fheroes2/issues/1728.

LeHerosInconnu avatar Sep 19 '20 12:09 LeHerosInconnu

Isn't it the same issue you talked about here #1728?

Branikolog avatar Sep 21 '20 19:09 Branikolog

@Branikolog.

Isn't it the same issue you talked about here #1728?

Yes, it's the same problem but in a different window. I would group the same type of issues in the same thread in the future.

LeHerosInconnu avatar Sep 22 '20 08:09 LeHerosInconnu

Should I close this for now?

Branikolog avatar Sep 22 '20 10:09 Branikolog

@Branikolog.

Should I close this for now?

Why? Are these two windows managed by the same part of the code?

LeHerosInconnu avatar Sep 22 '20 10:09 LeHerosInconnu

Yes. information bar for all of this windows is the same, as well, as text font. So, the issues regarding font shadows, are part of the same code.

Branikolog avatar Sep 22 '20 12:09 Branikolog

@Branikolog.

Yes. information bar for all of this windows is the same, as well, as text font. So, the issues regarding font shadows, are part of the same code.

Do what you think is best to get the job done right. :)

LeHerosInconnu avatar Sep 22 '20 12:09 LeHerosInconnu

It's ok! :) You can always ask me in discord for the cases, you're not sure about. Or here, at a similar topic, if you find one.

Branikolog avatar Sep 22 '20 12:09 Branikolog

@Branikolog.

It's ok! :) You can always ask me in discord for the cases, you're not sure about. Or here, at a similar topic, if you find one.

Okay, thank you.

LeHerosInconnu avatar Sep 22 '20 14:09 LeHerosInconnu

The text just needs to be shifted up one pixel: image

zenseii avatar Sep 17 '22 21:09 zenseii

Hello @zenseii,

The text just needs to be shifted up one pixel: image

I think that it will unbalance the visual in the case of a text with no letters with a jamb (letters of the Latin alphabet with a jamb: " g ", " j ", " p ", " q " et " y "). Better not to display the shadow of the letters with jamb over the yellow frame, which is the case in the original game for some screens.

In original game:

No shadow over yellow frame letter with jamb 01

Edit.

Or the vertical position of the text can be adjusted depending on whether the text contains letters with a jamb or not.

LeHerosInconnu avatar Sep 18 '22 17:09 LeHerosInconnu