fheroes2 icon indicating copy to clipboard operation
fheroes2 copied to clipboard

Heroes 2, text convention

Open LeHerosInconnu opened this issue 5 years ago • 13 comments

In the original game, there are two spaces at the start of each sentence after the dot "." of the previous sentence. This makes it easier to locate the beginning of each sentence and makes it easier to read. I suggest to apply this rule for all texts in fheroes2.

In the original game:

Graveyard search the graves 01

In fheroes2:

Graveyard search the graves 02

LeHerosInconnu avatar Aug 26 '20 10:08 LeHerosInconnu

This is the text composition in the original game. They explicitly add 2 spaces after the end of each sentence in most of messages.

ihhub avatar Sep 24 '20 14:09 ihhub

@ihhub.

This is the text composition in the original game. They explicitly add 2 spaces after the end of each sentence in most of messages.

Yes, exactly. There are also some oversights in the original game. This should be fixed in fheroes2.

LeHerosInconnu avatar Sep 24 '20 17:09 LeHerosInconnu

@LeHerosInconnu So just I understand correctly. We should have 2 spaces in fheroes2?

Mr-Bajs avatar Mar 21 '23 10:03 Mr-Bajs

Hello @Mr-Bajs,

@LeHerosInconnu So just I understand correctly. We should have 2 spaces in fheroes2?

In short, yes. :)

LeHerosInconnu avatar Mar 21 '23 14:03 LeHerosInconnu

Hi @Mr-Bajs and @LeHerosInconnu , the text in fheroes2 is more compact due to shorter width being used for a space symbol. It allow for many non-English languages fit words without being too short.

On the topic of this issue: in the past many people working in an IT industry tend to put 2 spaces after a sentence. It was just a habit and possibly to separate sentences. While it might be a benefit of doing this it is arguable that we should do.

ihhub avatar Mar 21 '23 14:03 ihhub

Hello @ihhub,

Hi @Mr-Bajs and @LeHerosInconnu , the text in fheroes2 is more compact due to shorter width being used for a space symbol. It allow for many non-English languages fit words without being too short.

On the topic of this issue: in the past many people working in an IT industry tend to put 2 spaces after a sentence. It was just a habit and possibly to separate sentences. While it might be a benefit of doing this it is arguable that we should do.

Indeed, there are also other languages. Maybe we shouldn't do it then. Or maybe only for the original language of the game, English?

LeHerosInconnu avatar Mar 21 '23 15:03 LeHerosInconnu

I am inclining towards having a modern way of text representation with a single space after a sentence. Now we have a mix of old style and new style and we have to choose one to be consistent.

What is your opinion @Branikolog and @zenseii?

ihhub avatar Aug 20 '23 14:08 ihhub

Hi, @ihhub and @LeHerosInconnu. Personally I think it looks better if we put such final questions on a new line: "Blah blah graves...\n" "Do you want to search the graves?"

This way you can easily find the important final part of the dialog and don't have to use double spaces.

zenseii avatar Aug 20 '23 14:08 zenseii

Hi @LeHerosInconnu and @zenseii , I think it is correlated to #1922 .

ihhub avatar Aug 20 '23 14:08 ihhub

Having the question for choice events on a seperate line looks better and makes the most important info for the player more accessible.

Mr-Bajs avatar Aug 20 '23 14:08 Mr-Bajs

I'm OK with a single space between sentences and I like an idea of a new line for questions in such windows.

Branikolog avatar Aug 25 '23 15:08 Branikolog

Hello @everyone,

I agree with a single space before the start of the next sentence, as long as this is applied throughout the game texts (at least in the game itself). Because it should also be considered that there are scenarios that use this way of putting two spaces before the start of the next sentence (introductory texts, event texts, etc.). So it's going to be difficult to have a really uniform way of writing in texts. If everyone agrees, this issue can be closed.

LeHerosInconnu avatar Aug 26 '23 21:08 LeHerosInconnu

Hello @ihhub,

Hi @LeHerosInconnu and @zenseii , I think it is correlated to #1922 .

Yes. :)

LeHerosInconnu avatar Sep 20 '23 22:09 LeHerosInconnu

Moving this out of the project scope as the current implementation allow to display much more text and users are used to play with our text convention.

ihhub avatar Oct 02 '25 06:10 ihhub