Isabella
Isabella
Hi @BlessedOneKobo, @chickenwaddle77 originally reported and was assigned this ticket so let's give him another shot at resolving. But if you are both open to collaborating, feel free to discuss...
Hey @lmarceau how can we get Danger not to fail the PR for this work? ## Error 1 > 🚫 SwiftUI 'Text(""' in file firefox-ios/firefox-ios-tests/Tests/XCUITests/C_AddressesTests.swift at line 683 needs to...
> > > 🚫 SwiftUI 'Text(""' in file firefox-ios/firefox-ios-tests/Tests/XCUITests/C_AddressesTests.swift at line 683 needs to be avoided, use Strings.swift localization instead. > > Yes, I have encountered the same type of...
@lmarceau is there a way we can ignore danger for the print statement in the tests? I didn't really want to actually _change_ any of the UI test code I...
@mergifyio rebase
Hi @DEADLK! Looks good! I'm just double checking regarding the `toast` vs. `toasts` naming you brought up on the ticket before merging. 😃 But I'm pretty sure we're sticking with...
Ok, I have verified the direction so we will keep the proposed naming. Thanks! 👌
> Hey [@ih-codes](https://github.com/ih-codes) assign it to me, please. > > Small note on naming. I see `toasts` being used in plural everywhere, but in the issue description you specified file...
Great investigation @Aniket-pd! I haven't dug into this myself but it definitely sounds like this could be the culprit. If you'd like to take a stab at some reworking to...
@adudenamedruby Looks like you took a first review on this, can you take another look to see if it's good? Thanks!