Adds adaptive speed functionality

[newice]

Press A to toggle adaptive speed. The speed then increases to double the preferred speed if video is silent and goes back to preferred speed if it is not silent anymore.

[ChadBailey]

I tried this out as-is without updating it, and I can't seem to get it to work? Can you provide steps for testing?

[ChadBailey]

All of the big changes that required this to be put on hold are behind us now. I've slated for 0.7 release if we can get it worked out before then. @newice Can you confirm with me how I can test this enhancement?

[newice]

How to test the enhancement:

• It does not work on Firefox(https://bugzilla.mozilla.org/show_bug.cgi?id=1517199) , only in chrome
• The key "A" triggers adaptive speed on and off.

Nothing else needed to set up.. @ChadBailey Did you have any errors in the console? I also addad a new button to the overlay controls. you can click it instead of the key.

[ChadBailey]

Nothing else needed to set up..

I was able to activate it, but in my tests it didn't actually do anything. I assume maybe it was just the lack of sufficient silence in the videos I tried? I'm unsure. This is why I was hoping for exact steps, like set the settings this way, go to this website, activate, from 0:00-1:50 you should see 1x speed, from 1:50-1:55 you should see 2.5x speed, etc.

[newice]

This video is silent between the speaking: https://www.youtube.com/watch?v=kcs82HnguGc

1. Start the Video
2. Hit 'A' ==>When you activate adaptive speed the speed should go from 1 to prefered speed (in my case 1.8)
3. As soon as the speaker stops talking the Speed switches to 2x preferred (in my case 3.6)
4. while active you can not change the speed because it gets resetted by adaptive speed.
5. When you deactivate adaptive speed it jumps to preferred speed (in my case 1.8).

Youtube hides the controls so you maybe don't see the change. Keep the mouse over the video moving to always see the current speed.

[ChadBailey]

thanks for the steps for testing. sorry for the delays in getting back to you, i've been busy with COVID-19 related tasks. i plan to test this soon

[newice]

Finally i was able to update my pullrequest. So if anyone has the time i would appreciate a feedback.

[igrigorik]

@newice this is, fascinating! I took for a quick test drive, a few questions..

• On YouTube my video periodically flashes to 0.0 (full pause) and then resumes -- guessing, that's not intended behavior?
• Have you done any testing on what the CPU impact is when this is enabled?

[newice]

@newice this is, fascinating! I took for a quick test drive, a few questions..

• On YouTube my video periodically flashes to 0.0 (full pause) and then resumes -- guessing, that's not intended behavior?

This is strange. I never had the speed go to 0.0 For the silent phases i changed the speed from two times the prefered speed to an own setting whichyou can set in the plugin options. Default is 3. Maybe the setting is missing for some reason?

• Have you done any testing on what the CPU impact is when this is enabled?

No unfortunately i have no experience in extended performance testing. activating the adaptive speed for the first time after page load usually takes about 0.1 second for me.

[fideliochan]

@newice @igrigorik @ChadBailey update on this please!