em-http-request icon indicating copy to clipboard operation
em-http-request copied to clipboard

Use cookiejar2 instead of cookiejar to support Ruby 3.3

Open MatheusRich opened this issue 1 year ago • 7 comments
trafficstars

Fixes #354

Regexp::new with 3 arguments is deprecated and fails on Ruby 3.3. The cookiejar gem repo has been archived, so let's use a new one.

MatheusRich avatar Jan 03 '24 20:01 MatheusRich

cc @igrigorik, @dorianmariefr

MatheusRich avatar Jan 03 '24 20:01 MatheusRich

Would hosting it under thoughtbot organisation help?

dorianmariecom avatar Jan 05 '24 17:01 dorianmariecom

I can also give push access to Raph e.g. anyone at thoughtbot

dorianmariecom avatar Jan 05 '24 17:01 dorianmariecom

Thanks for pushing on this!

The best outcome here would be to revive and find new stewards for the existing cookiejar repo and gem. em-http is one of a number of projects depending on it, and it would be a win for everyone if we could keep current pointers instead of fragmenting the landscape. I reached out to @dwaite earlier this week but have not heard back. Let's give him a bit more time to circle back. If he's awol, then—yes—an official cookiejar replacement repo with multiple owners would be the best path forward.

igrigorik avatar Jan 06 '24 02:01 igrigorik

My issue has been about concerns with supply chain attacks, as I am no longer active enough in the ruby community to judge the legitimacy of an a potential adopter of the library, and ruby gems (like most language dependency managers) is rather week in features protecting against or otherwise providing transparency to such changes.

The cookiejar gem got used more than I expected it to!

But it sounds like others are fine with @dorianmariefr adopting the library. I sent a request to add you to gem ownership to your GitHub-associated email address. Please take good care of the gem!

dwaite avatar Jan 06 '24 03:01 dwaite

@dwaite @dorianmariefr 👏🏻 ty both! 🙇🏻

igrigorik avatar Jan 08 '24 02:01 igrigorik

@dwaite sorry I saw your invite too late, could you resend please ?

dorianmariecom avatar Jan 18 '24 22:01 dorianmariecom

Would be great to get an update on this.

slavingia avatar Feb 18 '24 01:02 slavingia

@slavingia I got access to the cookiejar gem on rubygems

dorianmariecom avatar Feb 18 '24 10:02 dorianmariecom

Are we OK to resolve / close this? @dorianmariecom all good on your end, necessary fix in place?

igrigorik avatar Apr 29 '24 04:04 igrigorik

AFAIK, I released a fix before turning the reins over.

dwaite avatar Apr 29 '24 05:04 dwaite

@igrigorik nothing to fix right now, @dwaite did the fix a while ago, thanks to him.

So I think this can be closed

dorianmariecom avatar Apr 29 '24 10:04 dorianmariecom