em-http-request icon indicating copy to clipboard operation
em-http-request copied to clipboard

Immutable/Frozen String Compatibility

Open kenpropel opened this issue 8 years ago • 3 comments
trafficstars

Is Ruby's (potentially) upcoming Frozen String Literal compatibility in the roadmap?

Runtime option --enable-frozen-string-literal has been available since Ruby 2.3 and using this gives me RuntimeErrors with em-http v.1.1.5 so I'm curious what the take is with this project.

Thanks!

kenpropel avatar Jun 30 '17 23:06 kenpropel

Is there a tl;dr on the motivation and impact of this change in core? Not sure I fully grok either.

That said, happy to take/review PR's, if anyone is willing.. :-)

igrigorik avatar Jul 02 '17 21:07 igrigorik

Thanks for replying.

https://twitter.com/yukihiro_matz/status/634386185507311616 This is the most official it gets that I can find from Matz. But tl;dr it's for Ruby performance. Since it won't become default until 3.0 (which doesn't have a release date yet) there's no rush.

I was just curious because I started experimenting this frozen string option. I'll keep playing with some of my projects and see how this goes, or how soon the communities move towards this direction.

kenpropel avatar Jul 03 '17 04:07 kenpropel

Interesting, thanks for the heads up. As you can tell, not something on my radar.. but if anyone is interested in making a PR, I'd be happy to review.

igrigorik avatar Jul 03 '17 06:07 igrigorik