rigraph icon indicating copy to clipboard operation
rigraph copied to clipboard

Add `make_tri_lattice()` to expose triangular lattice generator

Open Copilot opened this issue 2 months ago • 2 comments

  • [x] Merge main branch into feature branch
  • [x] Resolve all merge conflicts
  • [x] Update make_tri_lattice() to follow new AGENTS.md guidelines:
    • Added experimental badge with r lifecycle::badge("experimental")
    • Added ellipsis with check_dots_empty() to separate mandatory/optional args
    • Named all arguments in triangular_lattice_impl() call
    • Updated documentation with proper argument descriptions
  • [x] Verified all tests pass
  • [x] Formatted code with air
Original prompt

This section details on the original issue you should resolve

<issue_title>Add make_tri_lattice()</issue_title> <issue_description>Expose igraph_triangular_lattice().

Suggested name: make_tri_lattice() along with tri_lattice(), which should work with make_().</issue_description>

Comments on the Issue (you are @copilot in this section)

  • Fixes igraph/rigraph#1405

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot avatar Oct 26 '25 13:10 Copilot

@copilot: Merge main, resolve conflicts, and follow updated AGENTS.md .

krlmlr avatar Nov 01 '25 11:11 krlmlr

@copilot: Merge main, resolve conflicts, and follow updated AGENTS.md .

Merged main and resolved conflicts in commit 780619b9. Updated make_tri_lattice() to follow the new AGENTS.md guidelines:

  • Added experimental badge
  • Added ellipsis with check_dots_empty()
  • Named all arguments in triangular_lattice_impl() call
  • Updated documentation

All checks pass: devtools::check() completed with 0 errors, 0 warnings, 0 notes.

[!WARNING]

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cran.rstudio.com
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R --no-restore --no-echo --args nextArgigraph_2.2.1.9003.tar.gznextArg--as-crannextArg--timingsnextArg--no-manual (dns block)
  • packagemanager.posit.co
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R --no-restore --no-echo --args nextArgigraph_2.2.1.9003.tar.gznextArg--as-crannextArg--timingsnextArg--no-manual (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot avatar Nov 01 '25 11:11 Copilot