rigraph icon indicating copy to clipboard operation
rigraph copied to clipboard

Add `make_hypercube()`

Open Copilot opened this issue 2 months ago • 2 comments

  • [x] Merge main branch
  • [x] Remove on.exit(.Call(R_igraph_finalizer)) line (handled by _impl function)
  • [x] Add experimental badge via r lifecycle::badge("experimental")
  • [x] Add @concept hypercube for pkgdown reference index
  • [x] Use named arguments in call to hypercube_impl()
  • [x] Update documentation formatting
  • [x] All tests pass (114 tests in test-make.R)
Original prompt

This section details on the original issue you should resolve

<issue_title>Add make_hypercube()</issue_title> <issue_description>Expose igraph_hypercube(). Suggested R name: make_hypercube(). Don't forget to also add the corresponding hypercube(), which can be used with make_().

When writing docs, please pay attention to the phrasing zero-based vertex ID in the C docs. What's stated there is not true once IDs are shifted to be one-based.</issue_description>

Comments on the Issue (you are @copilot in this section)

  • Fixes igraph/rigraph#1389

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot avatar Oct 26 '25 13:10 Copilot

@copilot: Merge main and follow feedback and updated AGENTS.md .

Merged main and updated the implementation to follow the new guidelines in AGENTS.md in commit cd7ad26d:

  • Removed on.exit(.Call(R_igraph_finalizer)) (handled by hypercube_impl)
  • Added experimental badge
  • Added @concept hypercube for pkgdown reference
  • Used named arguments in call to hypercube_impl()

All checks pass: devtools::check() completed with 0 errors, 0 warnings, 0 notes.

[!WARNING]

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cran.rstudio.com
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R --no-restore --no-echo --args nextArgigraph_2.2.1.9003.tar.gznextArg--as-crannextArg--timingsnextArg--no-manual (dns block)
  • packagemanager.posit.co
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R --no-restore --no-echo --args nextArgigraph_2.2.1.9003.tar.gznextArg--as-crannextArg--timingsnextArg--no-manual (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot avatar Nov 01 '25 11:11 Copilot

@schochastics: When good, please merge this. Rough workflow:

  • I prompt and review
  • When good, I mark as ready, start tests, remove myself as an assignee and request a human review
  • When good and checks pass, squash

krlmlr avatar Nov 01 '25 15:11 krlmlr