rigraph icon indicating copy to clipboard operation
rigraph copied to clipboard

Factor support

Open thomasp85 opened this issue 7 years ago • 3 comments

Fixes #34

In order to avoid conversion of factors attribute elements are initialised prior to assignment if the attribute does not exist or if the assignment is overwriting all elements within that attribute

thomasp85 avatar May 15 '17 19:05 thomasp85

FWIW, the failed build has nothing to do with this PR...

thomasp85 avatar May 16 '17 08:05 thomasp85

Are these changes present in the R igraph package? In my case, set_vertex_attr() and vertex_attr()<- both still convert factors to integers

mathlandry avatar Mar 30 '21 15:03 mathlandry

@mathlandry , no this code is not yet merged. This is a Pull Request with new proposed code that should still be integrated in the main codebase. After it will be merged, you can install it using remotes::install_github("igraph/rigraph@master"). I will try to do this shortly.

vtraag avatar Mar 30 '21 20:03 vtraag

Thank you for your contribution. This has conflicts now and needs to be redone. The original issue #34 has a reprex and points to this PR.

krlmlr avatar Apr 09 '24 14:04 krlmlr

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

aviator-app[bot] avatar Apr 09 '24 14:04 aviator-app[bot]