rigraph icon indicating copy to clipboard operation
rigraph copied to clipboard

Avoid using deprecated functions from igraph/C

Open krlmlr opened this issue 1 year ago • 3 comments

Change to #define IGRAPH_DEPRECATED __attribute__ ((__deprecated__)) and fix errors, one PR for each deprecated function.

krlmlr avatar Jan 30 '24 14:01 krlmlr

igraph_hub_score() and igraph_authority_score() are deprecated because it makes sense to always compute these two scores together (for efficiency, interpretability and to make sure we get a matching pair). The new function is called igraph_hub_and_authority_scores().

I suggest merging these two in R under the name hits_scores(). See https://en.wikipedia.org/wiki/HITS_algorithm for where the name comes from. This name is short and there's precedence (both Mathematica and NetworkX use a variation of it).

In the longer term I also suggest deprecating the separate hub_score() and authority_score() functions in favour of the combined one (hits_scores()).

The TL;DR of this comment is a suggestion on what to call the combined function.

szhorvat avatar Jan 30 '24 22:01 szhorvat

@szhorvat should this comment be a separate issue?

maelle avatar Feb 05 '24 11:02 maelle

Running revdepchecks.

krlmlr avatar May 31 '24 10:05 krlmlr