python-igraph icon indicating copy to clipboard operation
python-igraph copied to clipboard

Unnecessary dynamic memory allocation for matrices

Open iosonofabio opened this issue 3 years ago • 1 comments

Describe the bug During #529 @szhorvat noticed matrices are allocated dynamically in a few places where a static allocation would do and reduce the risk of memory leaks.

@ntamas found it in a few instances throughout, <10.

Let's fix that - I can make a PR after the UMAP one is merged

iosonofabio avatar Apr 17 '22 00:04 iosonofabio

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 19 '22 05:06 stale[bot]

I think this has been done; a quick grep for malloc and calloc revealed only a few places where we use dynamic allocations and they make sense in that context.

ntamas avatar Oct 14 '22 16:10 ntamas