Remove deprecated functions before 1.0

[szhorvat]

Old deprecated functions should be removed before the 1.0 release.

Add functions that shouldn't be removed, or whose removal needs discussion, to the following list (with a short reasoning):

• ... ?

[szhorvat]

List of deprecated functions:

igraph_centrality.h
193:IGRAPH_DEPRECATED IGRAPH_EXPORT igraph_error_t igraph_hub_score(const igraph_t *graph, igraph_vector_t *vector,
197:IGRAPH_DEPRECATED IGRAPH_EXPORT igraph_error_t igraph_authority_score(const igraph_t *graph, igraph_vector_t *vector,

igraph_paths.h
335:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_random_edge_walk(const igraph_t *graph,

igraph_conversion.h
62:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_get_sparsemat(const igraph_t *graph, igraph_sparsemat_t *res);
65:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_get_stochastic_sparsemat(const igraph_t *graph,

igraph_nongraph.h
108:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_zeroin(

igraph_foreign.h
53:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_read_graph_dimacs(igraph_t *graph, FILE *instream,
89:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_write_graph_dimacs(const igraph_t *graph, FILE *outstream,

igraph_bipartite.h
92:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_incidence(
97:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_get_incidence(
102:IGRAPH_EXPORT IGRAPH_DEPRECATED  igraph_error_t igraph_bipartite_game(

igraph_interface.h
146:IGRAPH_DEPRECATED IGRAPH_EXPORT igraph_error_t igraph_delete_vertices_idx(

igraph_structural.h
44:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_are_connected(const igraph_t *graph, igraph_integer_t v1, igraph_integer_t v2, igraph_bool_t *res);
166:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_laplacian(

igraph_topology.h
171:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_isomorphic_function_vf2(
220:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_subisomorphic_function_vf2(
315:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_isomorphic_34(

igraph_iterators.h
91:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_vs_seq(igraph_vs_t *vs, igraph_integer_t from, igraph_integer_t to);
92:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_vs_t igraph_vss_seq(igraph_integer_t from, igraph_integer_t to);
293:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_es_seq(igraph_es_t *es, igraph_integer_t from, igraph_integer_t to);
294:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_es_t igraph_ess_seq(igraph_integer_t from, igraph_integer_t to);

igraph_vector_pmt.h
37:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t FUNCTION(igraph_vector, init_seq)(TYPE(igraph_vector)*v, BASE from, BASE to);
40:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t FUNCTION(igraph_vector, copy)(
71:IGRAPH_EXPORT IGRAPH_DEPRECATED BASE FUNCTION(igraph_vector, e)(const TYPE(igraph_vector)* v, igraph_integer_t pos);
72:IGRAPH_EXPORT IGRAPH_DEPRECATED BASE* FUNCTION(igraph_vector, e_ptr)(const TYPE(igraph_vector)* v, igraph_integer_t pos);
297:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t FUNCTION(igraph_vector, move_interval2)(

igraph_hrg.h
126:IGRAPH_DEPRECATED IGRAPH_EXPORT igraph_error_t igraph_hrg_dendrogram(

igraph_games.h
222:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_erdos_renyi_game(

igraph_matrix_pmt.h
42:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t FUNCTION(igraph_matrix, copy)(
50:IGRAPH_EXPORT IGRAPH_DEPRECATED BASE FUNCTION(igraph_matrix, e)(
52:IGRAPH_EXPORT IGRAPH_DEPRECATED BASE* FUNCTION(igraph_matrix, e_ptr)(

igraph_config.h.in
38:#define IGRAPH_DEPRECATED_ENUMVAL @IGRAPH_DEPRECATED_ENUMVAL@

igraph_operators.h
93:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_subgraph_edges(

igraph_sparsemat.h
301:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_sparsemat_copy(
303:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_sparsemat_diag(
306:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_sparsemat_eye(

igraph_constructors.h
58:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_lattice(igraph_t *graph, const igraph_vector_int_t *dimvector, igraph_integer_t nei,
64:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_tree(igraph_t *graph, igraph_integer_t n, igraph_integer_t children,

[ntamas]

All of these seem okay to me, no reason not to remove them.

[szhorvat]

@krlmlr @Antonov548 Let us know if the removal of any of these would cause an issue for R/igraph

[krlmlr]

@Antonov548: can you please do a quick grep exercise in src/interface.c and src/interface_extra.c ?

[szhorvat]

@krlmlr The compiler should give warnings when you use a deprecated function (unless this was disabled—I don't remember). There was one deprecation I can recall since the last R release.

Please ignore the following, which will only become deprecated in 1.0:

igraph_interface.h
146:IGRAPH_DEPRECATED IGRAPH_EXPORT igraph_error_t igraph_delete_vertices_idx(

[Antonov548]

As long as I remember it was disabled.

[krlmlr]

The relevant PR in the R package is merged, do we need to do anything else here on the R side?

[szhorvat]

All of this is done, except igraph_hrg_dendrogram() which is replaced by igraph_from_hrg_dendrogram(). I don't like the naming of that function because it doesn't start with igraph_hrg_ like all other HRG functions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.