react-notification-system icon indicating copy to clipboard operation
react-notification-system copied to clipboard

Published 20 hours ago • verified publisher icon igorprado

Update NotificationItem.jsx

Open gnain opened this issue 7 years ago • 6 comments

Remove of the height reset on render. This fixes the height of the notification, and prevents having dynamic children (with variable height) to be displayed properly. Should also help in closing #77.

gnain avatar Apr 15 '17 15:04 gnain

Coverage Status

Coverage decreased (-0.01%) to 96.327% when pulling 2b74ff532e7d9ab2f5cc3d7f2086b67463b2800c on gnain:master into 7731449d4145c54b58332d46e353006942185da7 on igorprado:master.

coveralls avatar Apr 15 '17 15:04 coveralls

Also moved the call to onAdd in the callback of the setState

gnain avatar Apr 25 '17 16:04 gnain

Coverage Status

Coverage decreased (-0.01%) to 96.327% when pulling 1a3f91eaba6818747d8cf3192086dc966d059ed1 on gnain:master into 7731449d4145c54b58332d46e353006942185da7 on igorprado:master.

coveralls avatar Apr 25 '17 16:04 coveralls

What's the status of this?

ssilve1989 avatar May 10 '17 17:05 ssilve1989

Waiting for PR acceptation, and new release of the PR is or for you.

On Wed, 10 May 2017, 19:17 Steven Silvestri, [email protected] wrote:

What's the status of this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/igorprado/react-notification-system/pull/95#issuecomment-300551801, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjEjNFB-Piyr3TFpnSVfk2Wn9fTa4HIks5r4fE4gaJpZM4M-YPB .

gnain avatar May 10 '17 17:05 gnain

Any update on this? @igorprado

burtek avatar Apr 05 '18 09:04 burtek