active_storage_validations icon indicating copy to clipboard operation
active_storage_validations copied to clipboard

Published 20 hours ago • verified publisher icon igorkasyanchuk

Matchers - Add matchers for all validators

Open Mth0158 opened this issue 1 year ago • 7 comments

Some validators do not have their matcher, it should be implemented.

List of missing matchers:

  • limit
  • processable_image

Mth0158 avatar Nov 07 '23 09:11 Mth0158

Hey @Mth0158 - I'd love to work on this issue, can you please assign it to me? Thanks.

chahmedejaz avatar Nov 08 '23 19:11 chahmedejaz

Hi @chahmedejaz! Thanks for your message, I have just assigned the ticket to you. Just to let you know, it's better if you wait a few days to start this one, a lot of things will be refactored on the matcher part once #206 is merged :)

Mth0158 avatar Nov 08 '23 19:11 Mth0158

Hi @chahmedejaz! Thanks for your message, I have just assigned the ticket to you. Just to let you know, it's better if you wait a few days to start this one, a lot of things will be refactored on the matcher part once #206 is merged :)

Sure, thanks for the heads up :)

chahmedejaz avatar Nov 08 '23 19:11 chahmedejaz

@chahmedejaz it's been merged if you want to start this one

Mth0158 avatar Nov 12 '23 10:11 Mth0158

Thanks for letting me know @Mth0158. I'll pick this up now :)

chahmedejaz avatar Nov 12 '23 10:11 chahmedejaz

Hi @chahmedejaz, Any update on this PR? FYI, the AspectRatioValidatorMatcher has already been developed by #153, sorry for that if you've coded it

Mth0158 avatar Dec 01 '23 16:12 Mth0158

Hi @chahmedejaz, Any update on this PR? FYI, the AspectRatioValidatorMatcher has already been developed by #153, sorry for that if you've coded it

Hey @Mth0158 - I'm working on it. Sorry I got overbooked with issues. I'll submit the PR soon, thanks for the update. 👍

chahmedejaz avatar Dec 01 '23 19:12 chahmedejaz