active_storage_validations icon indicating copy to clipboard operation
active_storage_validations copied to clipboard

Published 20 hours ago • verified publisher icon igorkasyanchuk

Add simplecov as a Development dependency

Open Animesh-Ghosh opened this issue 2 years ago • 3 comments

Added simplecov as per this comment.

Animesh-Ghosh avatar Apr 19 '22 15:04 Animesh-Ghosh

Also, would adding a .ruby-version file make sense? If so, which version do we want it to have?

Animesh-Ghosh avatar Apr 19 '22 15:04 Animesh-Ghosh

@Animesh-Ghosh I don't think adding a .ruby-version makes sense since there is a test matrix for multiple ruby versions: https://github.com/igorkasyanchuk/active_storage_validations/blob/7e864bace93aac6816fb8d72d736e274c85787be/.github/workflows/minitest.yml#L9-L13

It might also be interesting to combine this addition with some CI pipeline to communicate how the new PR impacts the code coverage.

StefSchenkelaars avatar Oct 05 '22 13:10 StefSchenkelaars

@Animesh-Ghosh please fix the conflicts before I merge

igorkasyanchuk avatar Oct 12 '22 17:10 igorkasyanchuk

@igorkasyanchuk conflicts fixed.

Apologies for the delay!

Animesh-Ghosh avatar Nov 28 '22 19:11 Animesh-Ghosh

Thanks a lot @Animesh-Ghosh! 🥳

gr8bit avatar Jan 18 '23 21:01 gr8bit