Igor Kamyşev

Rule: `strict-event-calls`

1

If an event is called in effect-handler or `.watch` callback, it'll preserve current `scope`. In other cases it should be bound to scope. It's a rule for `scope`-preset.

For users are not using `babel-plugin`.

fixes #91 - [ ] docs - [x] imports - [x] implementation - [ ] non-date cases (Buffer?? custom classes??)

Rule: `no-obvious-cycle`

2

I've found a code in some codebases like this: ``` forward({ from: submit, to: submit }); ``` Of course, it leads to bug. We can detect such cases in linter.

Rule: `prefer-serializable-value-in-store`

1

This code ```ts const $data = createStore(new Date()) const setData = createEvent() const scope1 = fork() await allSettled(setData, { scope: scope1, params: new Date('2020-01-01') }) const json = JSON.stringify(serialize(scope)) const...

```ts sample({ source: $somestore, target: createEffect() }) ```

`undefined` used in Effector as a marker for skipping update in store. It can be hard to understand, if `undefined` is implicit used in store. E.g. ```ts const $list =...

Rule: `no-mutation-in-pure-functions`

2

Some functions in effector API should be pure: + reducer in `.on`-call + combinator (`fn`) in `sample` + filter in `guard`, `.filter` and `.filterMap` + mapper in `.map` and `.prepend`...

We discussed `combine(...)` many times in Telegram. It's a bad way, let's add a warning for it.

## Proposal After merging all hooks to main package, `*/scope` binds will obsolete, so we can safely delete it. I purpose deprecation in 23 and deletion in 24. `babel-plugin` should...