parglare icon indicating copy to clipboard operation
parglare copied to clipboard
verified publisher icon igordejanovic

Added grammar builder

Open hosford42 opened this issue 5 years ago • 3 comments

Code review checklist

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • [ ] Title summarizes what is changing
  • [ ] Commit messages are meaningful (see this for details)
  • [ ] Tests have been included and/or updated
  • [ ] Docstrings have been included and/or updated, as appropriate
  • [ ] Standalone docs have been updated accordingly
  • [ ] Changelog(s) has/have been updated, as needed (see CHANGELOG.md, no need to update for typo fixes and such).

hosford42 avatar Sep 13 '20 03:09 hosford42

Hi, @igordejanovic! Let me know if this needs anything to get it up to par.

hosford42 avatar Sep 13 '20 03:09 hosford42

@hosford42 Thanks much for the contribution! I just skimmed through the implementation and it looks very good. I'll do the full review in the next couple of days.

igordejanovic avatar Sep 14 '20 10:09 igordejanovic

Hi @igordejanovic. I'll try to get these changes done later today. Thanks for the feedback, and I'm happy to hear you are pleased.

hosford42 avatar Sep 24 '20 16:09 hosford42