fastcrud icon indicating copy to clipboard operation
fastcrud copied to clipboard

[WIP] Missing sqlalchemy operators

Open JakNowy opened this issue 1 year ago • 1 comments

[WIP] Feel free to leave any comments or requests.

JakNowy avatar May 13 '24 23:05 JakNowy

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (03d4a2d) to head (f8f8713). Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #85    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           68        70     +2     
  Lines         4819      5425   +606     
==========================================
+ Hits          4819      5425   +606     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 13 '24 23:05 codecov[bot]

@igorbenav this is ready for review. I'm going to add some docs tomorrow.

JakNowy avatar May 28 '24 22:05 JakNowy

I think all that's missing are typing fixes and docs and we're good to go

igorbenav avatar Jun 01 '24 22:06 igorbenav

@igorbenav Added docs and fixed checks. The latest commit makes the code a bit less clean, but it satisfies mypy, it's up to you if you want to keep it. Let me know your thoughts!

JakNowy avatar Jun 09 '24 15:06 JakNowy

Looking really good, @JakNowy, great work!

igorbenav avatar Jun 11 '24 02:06 igorbenav