Fix the data passed in page:done event

Open PikachuEXE opened this issue 11 years ago • 3 comments

https://github.com/igor-alexandrov/wiselinks/pull/62 breaks what the readme says about data:

page:done ($target, status, url, data)

Event is triggered if the request succeeds.

    $target – jQuery object that was updated with the request;

    status – a string describing the status;

    url – url of the request;

    data – content of the request;

Now it always passes the target DOM, but I expect a full document when it is returned by request from server/browser cache to do some custom update

Mar 20 '14 09:03 PikachuEXE

@igor-alexandrov I would like to have some clarification on data – content of the request Is it intended to be always the content of request or only the target DOM?

Mar 21 '14 05:03 PikachuEXE

@igor-alexandrov Please take a look if you have time :)

May 02 '14 02:05 PikachuEXE

@igor-alexandrov Can you take a look?

Oct 28 '14 09:10 PikachuEXE