Ignacio Lago comments

Results 22 comments of


                                            Ignacio Lago

Added support for brotli ('br') content-encoding

Is this feature stuck for some specific reason? Is there something that can be done to fix it?

[@types/express] Namespace 'serveStatic' has no exported member 'RequestHandlerConstructor'

Removing the @types/express dependency fixed the issue in a API project based on Express (without NestJS). Upgrading server-static typing dependencies did not work in my case.

Documentation for `limit`

Thanks for your feedback @therji-motif . I will review the implementation and update the documentation accordingly. My apologies for the inaccuracy.

download - no more

Get it here: https://github.com/darrinhenein/VerticalTabs/raw/master/VerticalTabs.xpi

kube-api log ListAndWatch error: failed to list redis.redis.opstreelabs.in/v1beta1, Kind=RedisReplication: conversion webhook for redis.redis.opstreelabs.in/v1beta2

We're also dealing with this issue. Thanks a lot, @MoZadro, for sharing your workaround!

Optimize `_sortNodeUp/Down` methods and `_moveNode` method (11x improvement)

This PR must point to `next` branch to create a pre-release first. I will do it as soon as possible and push this forward.

Add `profiling` directory for profiling the heap push & pop implementation (related issue #661)

As long as it is not packaged, it is an improvement. Thanks for the initiative.

Improve or supplement `contains` and `remove` functions

Indeed, there is an unexpected behavior here. This must be a TDD with your example as the test itself. Thanks for your feedback @CarlOlson. Willing to provide a PR draft?

Iteration consuming the heap is maybe too surprising

Thank you for your feedback, @jedwards1211. You raise a valid point. I have never been entirely comfortable with it, as it can feel like a dark pattern. This behavior occurs...