openfire-monitoring-plugin icon indicating copy to clipboard operation
openfire-monitoring-plugin copied to clipboard

Ensure Log API fetches for all rooms

Open Fishbowler opened this issue 2 years ago • 0 comments

#222 spotted some deprecated methods after bumping the minimum Openfire version #223 spotted that the reason getChatRooms() was deprecated was because it fetched in-memory chat rooms only (and had been replaced with an equivalent getActiveChatRooms()

Update the implementation to inspect all rooms when needed, not just the ones in memory/cache. Beware memory utilisation - iterating over all unused MUCs in the DB could be expensive.

https://github.com/igniterealtime/openfire-monitoring-plugin/blob/5bab10a2bd14decc3ef217f43f8ff8a808406f35/src/java/org/jivesoftware/openfire/plugin/service/LogAPI.java#L65

https://github.com/igniterealtime/openfire-monitoring-plugin/blob/5bab10a2bd14decc3ef217f43f8ff8a808406f35/src/java/org/jivesoftware/openfire/plugin/service/LogAPI.java#L91

Fishbowler avatar Jul 06 '22 12:07 Fishbowler