Smack icon indicating copy to clipboard operation
Smack copied to clipboard

[sinttest] Additional Pubsub integration tests

Open Flowdalic opened this issue 4 years ago • 4 comments

For XEP-0060 § 7.1.2. Asserts that publishing an item with the same ID overwrites the previous item with that ID.

For XEP-0060 § 8.4.1: Assert that the server send a notification to subscribers when deleting a node that exists.

Test for XEP-0060 § 8.4.3.2: Asserts that the server returns an 'item-not-found' error response when deleting a node that does not exist.

Tests for non-optional ('MUST') conditions in XEP-0060 § 6.2

Tests for non-optional ('MUST') conditions in XEP-0060 § 6.1.6

Tests for non-optional ('MUST') conditions in XEP-0060 § 6.1.4

Tests for non-optional ('MUST') error conditions upon subscription (XEP-0060 § 6.1.3).

Co-authored-by: Paul Schaub [email protected] Co-authored-by: Florian Schmaus [email protected]

Thank you for your contribution!

Flowdalic avatar Jan 25 '21 19:01 Flowdalic

A first run on my end showed that some tests fail. I don't know the root cause (yet).

Flowdalic avatar Jan 25 '21 19:01 Flowdalic

:eyes:

Fishbowler avatar Nov 06 '22 13:11 Fishbowler

I've fixed them, but can't push direct to your branch. Rebased and fixed here: https://github.com/Fishbowler/Smack/tree/pubsub-sinttests

Fishbowler avatar Nov 06 '22 15:11 Fishbowler

The current state of PubSubIntegrationTest as it exists @Fishbowler's branch have now been added to a new repository, https://github.com/igniterealtime/smack-sint-server-extensions, which aims to include tests that are server-oriented.

If there is no desire to merge these changes into Smack's repository, then this PR can be closed.

guusdk avatar Jan 17 '23 16:01 guusdk