Openfire icon indicating copy to clipboard operation
Openfire copied to clipboard

OF-1838 XEP-0157: Improve support

Open mnsuccess opened this issue 6 years ago • 15 comments

XEP-0157 support in Openfire should be improved upon. Ideally, the admin console is used to determine what users are exposed as what kind of XEP-0157 contact.

mnsuccess avatar Sep 02 '19 10:09 mnsuccess

Do we need a servlet for this? It's not a bad approach, but we hardly use servlets, and do everything in JSP. If there's a reason for having a servlet, I'm not against it.

guusdk avatar Sep 02 '19 11:09 guusdk

I've used servlets in a couple of places (e.g. the new System properties page). Possibly my bad for not highlighting that at the time, but ...

I'd encourage use of servlets. It does make things far neater, IMHO. A much cleaner seperation of logic and display, less likely to get CSRF problems, etc. etc.

GregDThomas avatar Sep 02 '19 11:09 GregDThomas

I use both in plugins and would like to keep both options open. Slightly different tools to achieve the same purpose.

deleolajide avatar Sep 02 '19 11:09 deleolajide

I agree that using servlets is generally a good idea. In this instance, I'd like to keep the code somewhat consistent.

I'd be happy to introduce Servlets, but then I'd ask you to introduce them everywhere. :)

guusdk avatar Sep 02 '19 15:09 guusdk

I'd like to see servlets everywhere, but practically speaking I think the only way you're going to get it done is a few at a time.

GregDThomas avatar Sep 02 '19 15:09 GregDThomas

Three years in, we're still halfway through JSTL :(

guusdk avatar Sep 02 '19 15:09 guusdk

@mnsuccess why prefix every column name with the letter 'c'?

guusdk avatar Sep 03 '19 10:09 guusdk

@mnsuccess why prefix every column name with the letter 'c'? prefix c as a contact. I wanted to prefix with the word contact it seemed long then I just prefixed it with c. maybe we don't need to prefix column

mnsuccess avatar Sep 03 '19 10:09 mnsuccess

Ah I see. It's a bit redundant as there will only be contacts in that table anyway, but hey :)

guusdk avatar Sep 03 '19 11:09 guusdk

Should I keep using servlet ?

mnsuccess avatar Jun 27 '20 11:06 mnsuccess

Using servlets is fine, but please stop using the letter c as the first letter of each database column name.

guusdk avatar Jun 29 '20 07:06 guusdk

@mnsuccess Are you still working on this PR?

akrherz avatar Aug 16 '20 10:08 akrherz

@akrherz yes I'm still working on this !!

mnsuccess avatar Aug 16 '20 10:08 mnsuccess

Hi @mnsuccess, are you able to rebase this PR onto current master?

akrherz avatar Oct 20 '20 15:10 akrherz

@mnsuccess: Have you progressed?

Neustradamus avatar Oct 01 '21 00:10 Neustradamus