cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: Add multi node (validator) testnet

Open likesToEatFish opened this issue 1 year ago • 15 comments

Closes: #4374

This PR added the feature to ignite multi-node testnet.

Test steps:

  1. ignite scaffold chain github.com/test/mychain
  2. cd mychain
  3. go install ./...
  4. ignite testnet multi-node

The interface looks like this:

image

likesToEatFish avatar Sep 29 '24 16:09 likesToEatFish

The feature is done, but the documentation hasn't been written yet. I plan to complete it tomorrow.

likesToEatFish avatar Sep 29 '24 16:09 likesToEatFish

Hey, we've changed a bit the requirements and simplified the config.yaml: https://github.com/ignite/cli/issues/4374#issuecomment-2386058282

In short, we should use the existing validators section for multi-node. We should add a comments that says the fist validator is used in chain serve and all validators are used in testnet multi-node. For random, less not have them in the config.yaml anymore, but just let multi-node take a flag.

julienrbrt avatar Oct 01 '24 14:10 julienrbrt

Here is the new display result, there will be 5 daemon lines for each node:

image

likesToEatFish avatar Oct 05 '24 06:10 likesToEatFish

we should use the existing validators section for multi-node.

And I modified the use of the existing validators section for multi-node.

likesToEatFish avatar Oct 05 '24 06:10 likesToEatFish

@likesToEatFish can you change the command so we can use the chain serve instead of the new multi-node command

https://github.com/ignite/cli/issues/4374#issuecomment-2383475390

Pantani avatar Oct 11 '24 19:10 Pantani

@likesToEatFish can you change the command so we can use the chain serve instead of the new multi-node command

#4374 (comment)

I added in vaildators image

likesToEatFish avatar Oct 13 '24 14:10 likesToEatFish

@likesToEatFish can you change the command so we can use the chain serve instead of the new multi-node command

https://github.com/ignite/cli/issues/4374#issuecomment-2383475390

I don't think it should use chain serve. The validator field makes sense but chain serve should be imho for a single validator.

julienrbrt avatar Oct 13 '24 15:10 julienrbrt

I added color to the console screen @julienrbrt , it looks like this:

image

likesToEatFish avatar Oct 13 '24 16:10 likesToEatFish

Thanks! Are you able to add a sort a menu/status bar to quit a node easily? So that it has a real TUI feeling

julienrbrt avatar Oct 13 '24 21:10 julienrbrt

Just as a way to tell/let the user how to kill/restart a node easily. Then I think it's good to go 👍

julienrbrt avatar Oct 13 '24 21:10 julienrbrt

do you mean it looks like this: image

likesToEatFish avatar Oct 14 '24 03:10 likesToEatFish

@likesToEatFish any thought about it? Why did you marked as solved?

https://github.com/ignite/cli/pull/4377#discussion_r1797366160

Pantani avatar Oct 14 '24 14:10 Pantani

@likesToEatFishBạn có suy nghĩ gì về vấn đề này không? Tại sao bạn đánh dấu là đã giải quyết?

#4377 (bình luận)

Sorry, I replied but for some reason it is pending

image

likesToEatFish avatar Oct 14 '24 15:10 likesToEatFish

I apologize for the many comments I've provided that are still pending. I didn't notice their status, which serves as a lesson for me to stay more attentive in the future.

likesToEatFish avatar Oct 14 '24 15:10 likesToEatFish

Thanks @julienrbrt @Pantani , I learned a lot of new things from this PR! 🙏🏾

likesToEatFish avatar Oct 20 '24 07:10 likesToEatFish

Hi @julienrbrt @Pantani , I noticed the PR received positive feedback a few days ago but hasn't been merged yet. If there's anything further needed from my side or any blockers, please let me know. Thanks!

likesToEatFish avatar Oct 27 '24 03:10 likesToEatFish

Hey! I'll be reviewing this today! Sorry about the delay (cosmoverse + holidays :D)

julienrbrt avatar Nov 06 '24 18:11 julienrbrt