cli icon indicating copy to clipboard operation
cli copied to clipboard

feat(pkg): improve xgenny dry run (backport #4001)

Open mergify[bot] opened this issue 1 year ago • 2 comments

close #2565

Description

Improve the xgenny package by creating a custom runner to salve all modifications into a temporary folder and only apply and copy all files to the target directory later.

Changes

This PR removes the default dry and wet runners, avoiding running two generators. If everything works fine, only one will run into a temporary folder and be copied to the target folder.


This is an automatic backport of pull request #4001 done by Mergify.

mergify[bot] avatar Jul 02 '24 14:07 mergify[bot]

Cherry-pick of 2ad41ee31f9b6dc8550cca5d61c89df6c351e524 has failed:

On branch mergify/bp/release/v28.x.y/pr-4001
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 2ad41ee3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	modified:   go.mod
	deleted:    ignite/cmd/scaffold_package.go
	new file:   ignite/pkg/xgenny/runner.go
	renamed:    ignite/pkg/xgenny/xgenny.go -> ignite/pkg/xgenny/walker.go
	renamed:    ignite/pkg/xgenny/xgenny_test.go -> ignite/pkg/xgenny/walker_test.go
	modified:   ignite/services/plugin/scaffold.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   ignite/cmd/chain.go
	both modified:   ignite/cmd/scaffold.go
	both modified:   ignite/cmd/scaffold_chain.go
	deleted by us:   ignite/cmd/scaffold_configs.go
	both modified:   ignite/cmd/scaffold_message.go
	both modified:   ignite/cmd/scaffold_module.go
	both modified:   ignite/cmd/scaffold_packet.go
	deleted by us:   ignite/cmd/scaffold_params.go
	both modified:   ignite/cmd/scaffold_query.go
	deleted by them: ignite/pkg/xgenny/run.go
	both modified:   ignite/services/chain/init.go
	both modified:   ignite/services/chain/proto.go
	both modified:   ignite/services/doctor/doctor.go
	deleted by us:   ignite/services/scaffolder/configs.go
	both modified:   ignite/services/scaffolder/init.go
	both modified:   ignite/services/scaffolder/message.go
	both modified:   ignite/services/scaffolder/module.go
	both modified:   ignite/services/scaffolder/packet.go
	deleted by us:   ignite/services/scaffolder/params.go
	both modified:   ignite/services/scaffolder/query.go
	both modified:   ignite/services/scaffolder/scaffolder.go
	both modified:   ignite/services/scaffolder/type.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify[bot] avatar Jul 02 '24 14:07 mergify[bot]

Visit the preview URL for this PR (updated for commit c312a37):

https://igntservices-docs--pr4234-mergify-bp-release-v-00v5xbcs.web.app

(expires Thu, 11 Jul 2024 14:22:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

github-actions[bot] avatar Jul 02 '24 14:07 github-actions[bot]