cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: remove `protoc` pkg and also nodetime helpers `ts-proto` and `sta` (backport #4090)

Open mergify[bot] opened this issue 1 year ago • 1 comments

Description

stop using the protoc with the node plugins so we can remove the node time binary. This PR's makes all ts generation using the buf generate command.

Changes

  • Move buf mode update to buf dep update;
  • Remove protoc and nodetime;
  • Add buf.lock dependency digest;

How to test

ignite s chain venus && cd venus && ignite g ts-client

check the ts-client folder into the chain


This is an automatic backport of pull request #4090 done by Mergify.

mergify[bot] avatar Jul 01 '24 18:07 mergify[bot]

Cherry-pick of 8e0937d9f47c96dbd0db8d5f7058d0f636ba3428 has failed:

On branch mergify/bp/release/v28.x.y/pr-4090
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 8e0937d9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .gitignore
	modified:   changelog.md
	modified:   ignite/pkg/cosmosanalysis/app/testdata/modules/app_config/go.mod
	modified:   ignite/pkg/cosmosanalysis/app/testdata/modules/runtime/go.mod
	modified:   ignite/pkg/cosmosanalysis/app/testdata/modules/single_app/go.mod
	modified:   ignite/pkg/cosmosanalysis/app/testdata/modules/spn/go.mod
	modified:   ignite/pkg/cosmosgen/generate.go
	new file:   ignite/pkg/cosmosgen/sta.go
	modified:   ignite/pkg/cosmosver/testdata/chain-sdk-local-fork/go.mod
	modified:   integration/cosmosgen/cosmosgen_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   go.mod
	both modified:   go.sum
	both modified:   ignite/internal/plugin/testdata/execute_fail/go.mod
	both modified:   ignite/internal/plugin/testdata/execute_ok/go.mod
	deleted by us:   ignite/internal/tools/gen-config-doc/go.mod
	deleted by us:   ignite/internal/tools/gen-config-doc/go.sum
	deleted by us:   ignite/internal/tools/gen-mig-diffs/go.mod
	deleted by us:   ignite/internal/tools/gen-mig-diffs/go.sum
	both modified:   ignite/pkg/cosmosbuf/buf.go
	both modified:   ignite/pkg/cosmosgen/generate_go.go
	both modified:   ignite/pkg/cosmosgen/generate_openapi.go
	both modified:   ignite/pkg/cosmosgen/generate_typescript.go
	deleted by them: ignite/pkg/nodetime/nodetime.go
	deleted by them: ignite/pkg/nodetime/programs/sta/sta.go
	deleted by them: ignite/pkg/nodetime/programs/ts-proto/tsproto.go
	deleted by them: ignite/pkg/protoc/protoc.go
	both modified:   ignite/templates/app/files/go.mod.plush
	both modified:   ignite/templates/app/files/proto/buf.lock
	both modified:   integration/doctor/testdata/missing-tools.go.txt
	both modified:   integration/plugin/testdata/example-plugin/go.mod

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify[bot] avatar Jul 01 '24 18:07 mergify[bot]