cli icon indicating copy to clipboard operation
cli copied to clipboard

chore: lint tests

Open faddat opened this issue 1 year ago • 6 comments

Lint tests so that the codebase is consistently linted

  • bump golangci-lint
  • lint tests
  • add gci linter
  • enable errcheck linter

faddat avatar May 19 '24 16:05 faddat

gci is that linter, and it is configured in its standard way.

We could also configure it to group like how was done in ibc, or sdk.

Ah, yeah I think I know exactly what you're looking for after checking the changeset.... moment

faddat avatar May 19 '24 17:05 faddat

@julienrbrt I think that checking errors found a bug. To make this easier to review, I'll separate the gci changes.

faddat avatar May 19 '24 18:05 faddat

@Pantani - actually that makes sense! Let me fix that issue with the import ordering.

Thanks for pointing it out.

faddat avatar May 21 '24 01:05 faddat

recommend merging this first:

  • https://github.com/ignite/cli/pull/4162

faddat avatar May 21 '24 01:05 faddat

great!! thanks for contributing @faddat

Pantani avatar May 21 '24 12:05 Pantani

@faddat, there are some merge conflicts. I think the problem is because the cleanup method into the cosmosbuf pkg was removed

Pantani avatar May 27 '24 19:05 Pantani