cli icon indicating copy to clipboard operation
cli copied to clipboard

Remove placeholders from the template

Open fadeev opened this issue 1 year ago • 2 comments

Currently, placeholders exist in the following places in the standard template:

  • [ ] app/app.go
  • [ ] proto/
    • genesis.proto
    • query.proto
    • tx.proto
  • x/MODULE/
    • client/cli: the next version of the CLI will auto-generate CLI, so removing placeholders from here is not a priority
    • [ ] types/
      • codec.go
      • keys.go
      • genesis.go and genesis_test.go
    • [ ] genesis.go and genesis_test.go
    • [ ] module_simulation.go
  • cmd: should be removed by replacing cosmoscmd with something else

This issue is related to the discussion on Discord:

https://discord.com/channels/893126937067802685/907904892780290058/1020618039647027290

fadeev avatar Sep 17 '22 08:09 fadeev

Hey @fadeev, if you don't remember, I was behind the project for addressing this during the 2021 Hackathon.

I haven't really been keeping up to speed with the overall changes but I've been looking for a reason to finish this up and contribute back to the project.

(Note: saw the discussion on the ignite-cli-dev channel on Discord but I guess it is restricted for team-only, lmk if there's a more appropriate place to discuss this)

DimitrisJim avatar Sep 22 '22 08:09 DimitrisJim

Oh, hey, @DimitrisJim! The ignite-cl-dev channel is indeed the best place to discuss this. I've added you to the channel 🙌

fadeev avatar Sep 22 '22 11:09 fadeev

Hi @DimitrisJim, have you made any progress on this ? We'd like to move forward so if you don't have the time to work on it, no problem but we need to assign someone else.

tbruyelle avatar Nov 07 '22 09:11 tbruyelle

@tbruyelle yes! Had some other issues pop up but I should hopefully get a PR within the week.

DimitrisJim avatar Nov 07 '22 13:11 DimitrisJim

awesome !

tbruyelle avatar Nov 07 '22 15:11 tbruyelle