cli icon indicating copy to clipboard operation
cli copied to clipboard

ci: create a workflow to check `pkg/*` doesn't depend on

Open ilgooz opened this issue 2 years ago • 3 comments

any other packages in the CLI repo, except the ones inside pkg/*

ilgooz avatar May 11 '22 08:05 ilgooz

Script to get the list

$ go list -f '{{ .Deps }}' ./pkg/... | grep -Eo "github.com/ignite/cli/ignite/[^ ]*" | grep -v "github.com/ignite/cli/ignite/pkg" | sort | uniq
github.com/ignite/cli/ignite/chainconfig
github.com/ignite/cli/ignite/chainconfig/config
github.com/ignite/cli/ignite/chainconfig/v0
github.com/ignite/cli/ignite/chainconfig/v1
github.com/ignite/cli/ignite/services/chain
github.com/ignite/cli/ignite/services/network/networkchain
github.com/ignite/cli/ignite/services/network/networktypes

I can create the workflow, but how do you want github.com/ignite/cli/ignite/{chainconfig,services} to be managed ?

We moved them into pkg/ ?

albttx avatar Nov 15 '22 16:11 albttx

cc: @aljo242

albttx avatar Nov 25 '22 11:11 albttx

We shouldn't move them pkg imo. We should have a team discussion about what to do for this.

aljo242 avatar Nov 30 '22 15:11 aljo242