intellij-erlang icon indicating copy to clipboard operation
intellij-erlang copied to clipboard

fix can't resolve rebar version problem; fix sdk string mismatching

Open yidayoung opened this issue 5 years ago • 1 comments


fix #903 like issue said can't resolve rebar version problem on windows, seems just should use escript.getStdOut() not rebar.getStdOut()

https://github.com/ignatov/intellij-erlang/blob/8eb5f46096284707776a0e4b4594e86a57ee2df5/src/org/intellij/erlang/rebar/settings/RebarConfigurationForm.java#L97-L98


after this comit 0dfb40ea7a36b0a8e6987993a2f5ccc6d99a78c3[simplify visible erlang sdk name] should also change patten https://github.com/ignatov/intellij-erlang/blob/0dfb40ea7a36b0a8e6987993a2f5ccc6d99a78c3/src/org/intellij/erlang/sdk/ErlangSdkRelease.java#L34 https://github.com/ignatov/intellij-erlang/blob/0dfb40ea7a36b0a8e6987993a2f5ccc6d99a78c3/src/org/intellij/erlang/sdk/ErlangSdkRelease.java#L63-L64

or ErlangSdkType.detectSdkVersion will always call erl, but not all time can use OSProcessHandler, it will make error ERROR - ution.process.OSProcessHandler - Synchronous execution on EDT

yidayoung avatar Nov 17 '20 03:11 yidayoung

OTP version can be read from SdkRoot/releases/xx/OTP_VERSION and ERTS version can be found from SdkRoot/erts-xxx directory name. I will soon create a merge request for that and also will look at this code here

kvakvs avatar Nov 16 '22 11:11 kvakvs