ducalis
ducalis copied to clipboard
ignat-z
RuboCop based static code analyzer for enterprise Rails applications.
There are several open issues and no activity for months or even years. Is that gem still a thing?
given a change like so: ```git diff --git a/lib/offending_engine/harvesters/ruby/ducalis/isolate/Gemfile.lock b/lib/offending_engine/harvesters/ruby/ducalis/isolate/Gemfile.lock index fe805f7..bd39031 100644 --- a/lib/offending_engine/harvesters/ruby/ducalis/isolate/Gemfile.lock +++ b/lib/offending_engine/harvesters/ruby/ducalis/isolate/Gemfile.lock @@ -10,7 +10,7 @@ GEM regexp-examples (~> 1.3, >= 1.3.2) regexp_parser (>= 0.5.0)...
Given gemfile and lock: ```ruby # frozen_string_literal: true source 'https://rubygems.org' gem 'ducalis' ``` ``` GEM remote: https://rubygems.org/ specs: addressable (2.5.2) public_suffix (>= 2.0.2, < 4.0) ast (2.4.0) ducalis (0.12.0) git...
Need to add more info why module like classes aren't so good: - What about performance - What about refactoring - Think about merging `Ducalis::OnlyDefs` and `Ducalis::ModuleLikeClass`
Something has changed between 0.7 and 0.8 and it is hard to say what :(
I think it could be a nice improvement if ducalis would write a specific for each (or at least some) rubocop:disable rule message, stating why this concrete disable is not...
> Rule of thumb: count one for each group, join, having, where, order in your query. More than three? Things will :boom: blow up. https://deliveroo.engineering/guidelines/active-record/#query-objects