iggy icon indicating copy to clipboard operation
iggy copied to clipboard

implement fmt::Display for Partition

Open arembridge opened this issue 9 months ago • 4 comments

Implement the Display functionality for Partition (similar to topic.rs )

PR raised as an initial response to: https://github.com/iggy-rs/iggy/issues/481

Please let me know if you are happy with these changes. If so, I can also implement Segment and Stream!

arembridge avatar May 06 '24 14:05 arembridge

Looks good, but please also use it whenever possible :)

hubcio avatar May 06 '24 14:05 hubcio

Pull Request Test Coverage Report for Build 8971001847

Details

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 82.533%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/src/streaming/partitions/partition.rs 0 8 0.0%
<!-- Total: 0 8
Files with Coverage Reduction New Missed Lines %
sdk/src/binary/system.rs 1 96.97%
sdk/src/cli/client/get_client.rs 1 64.29%
<!-- Total: 2
Totals Coverage Status
Change from base Build 8934395468: -0.03%
Covered Lines: 22520
Relevant Lines: 27286

💛 - Coveralls

coveralls avatar May 06 '24 14:05 coveralls

@alexander-rembridge have you already joined our discord? what's ur username?

hubcio avatar May 08 '24 14:05 hubcio

@alexander-rembridge have you already joined our discord? what's ur username?

@rembridge

arembridge avatar May 08 '24 15:05 arembridge