Igal

Results 31 comments of Igal

@wilcraig Hey thanks for pushing the changes. Unfortunately version 0.3.5 doesn't play videos. It appears that the changes I provided were partial. That's because the `src/angular-embedplayer.js` file doesn't pull with...

@wilcraig thanks, I confirm that v0.3.6 can be imported and works!

Greetings from https://mapme.com 🌍 🤓 Amazing work on V3. We can't wait to start using it 🙏🏼 Unfortunately this issue blocks our upgrade. We serve maps with a style-toggle button,...

Adding code to reproduce the issue: https://codepen.io/igal1c0de4n/pen/MWzogJa It displays a button to switch styles. The first setStyle sends `style.load` as expected. when using: ``` https://unpkg.com/[email protected]/dist/maplibre-gl.js ``` The 2nd button click...

Hi We started to look into it, not yet close to submitting a fix we're confident about. I can share that after analyzing #1805 we discovered the issue involves this...

@HarelM Are you saying that `style.load` firing needs to be moved from current location: https://github.com/maplibre/maplibre-gl-js/blob/main/src/style/style.ts#L368 to the end of `setStyle`: https://github.com/maplibre/maplibre-gl-js/blob/main/src/ui/map.ts#L1685 ? If so, we can prepare and test this...

Looking at the `setStyle` code: ```js setStyle(style: StyleSpecification | string | null, options?: StyleSwapOptions & StyleOptions) { options = extend({}, { localIdeographFontFamily: this._localIdeographFontFamily, validate: this._validateStyle }, options); if ((options.diff !==...

yes, it didn't prevent the initial connection attempt. I still see an http GET to the `/sockjs/info?...` path

In that case I'll clarify: I have a few meteor instances which are not set up as classic Meteor servers with ddp. They include the `cfs:http-methods` package, which provides Meteor...

Correct. In practice I use an environment variable to switch the server from REST methods to a reactive pubs/subs session. Reason is the scaling issue. Many sessions are 'good enough'...