mysql-pool-booster icon indicating copy to clipboard operation
mysql-pool-booster copied to clipboard

There is no information about connection failure

Open josef-rybicka-zz opened this issue 7 years ago • 2 comments

Hello, i've made a little improvement in your library for better handling connection errors. When you set invalid or non-existing mysql hostname or the server doesn't respond, there is no error to catch. You have no idea what is happening then.

For example:

const mysqlBoosted = MysqlPoolBooster(mysql);
const pool = mysqlBoosted.createPool(config);

pool.getConnection((err, conn) => {
	// err is never not-null
	return conn;
});

Do you have other ideas how to improve this to better error handling? Thank you for you work.

josef-rybicka-zz avatar Nov 29 '18 11:11 josef-rybicka-zz

@fyisch Thanks for your PR. I'm sorry I have not been interested in this project for a long time. I will think about what you mentioned and I will take care of it as soon as possible.

ifsnow avatar Nov 30 '18 04:11 ifsnow

Hello, could you please tell me whether there is any progress on my PR? Can I help with something? Thank you.

josef-rybicka-zz avatar Jan 09 '19 14:01 josef-rybicka-zz