mysqldump-php icon indicating copy to clipboard operation
mysqldump-php copied to clipboard

Published 20 hours ago • verified publisher icon ifsnop

Allow for trailing semicolon on connect string

Open phpfui opened this issue 4 years ago • 1 comments

A trailing semicolon is legal in PDO, but the library currently bombs is it is supplied. This PR allows for trailing (and sequential) semicolons in the connect string.

  • Could not run tests, as I only support PHP 7.1 and higher, but tests should run.
  • Added to .gitignore for future versions of PHPUnit
  • Added trailing semicolons in tests at semi random places, including identical connect strings, one with, and one without the semicolon.
  • Removed some trailing white space.

phpfui avatar Feb 02 '21 03:02 phpfui

Two of the Travis failures look like composer install issue. The third is due to an old version of PHPUnit that is no longer supported by PHP 8, which is the nightly build.

So this should be good to go.

phpfui avatar Feb 03 '21 03:02 phpfui