ifme icon indicating copy to clipboard operation
ifme copied to clipboard

Add a Storybook build to our Circle CI configuration

Open julianguyen opened this issue 2 years ago • 8 comments

Description

Let's add a Storybook build to our Circle CI configuration. We need to verify that merges to our repo do not break the Storybook build. If there are changes to files in /client, we want to verify that the Storybook build passes before a PR is mergeable.


Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

julianguyen avatar Oct 09 '22 16:10 julianguyen

Will give it a try

cristianmedeiros avatar Oct 12 '22 12:10 cristianmedeiros

That would be great, thank you, @cristianmedeiros!

julianguyen avatar Oct 12 '22 15:10 julianguyen

@cristianmedeiros are you working on this?

rajat-tomar avatar Oct 17 '22 14:10 rajat-tomar

Hi Rajat, yes, slowly, but yes

On Mon, Oct 17, 2022 at 11:13 AM Rajat Tomar @.***> wrote:

@cristianmedeiros https://github.com/cristianmedeiros are you working on this?

— Reply to this email directly, view it on GitHub https://github.com/ifmeorg/ifme/issues/2163#issuecomment-1280928549, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIAT6AN73ZSYLB3YHB6TTWDVNIHANCNFSM6AAAAAARAYLLA4 . You are receiving this because you were mentioned.Message ID: @.***>

cristianmedeiros avatar Oct 17 '22 14:10 cristianmedeiros

Hi Rajat, yes, slowly, but yes On Mon, Oct 17, 2022 at 11:13 AM Rajat Tomar @.> wrote: @cristianmedeiros https://github.com/cristianmedeiros are you working on this? — Reply to this email directly, view it on GitHub <#2163 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIAT6AN73ZSYLB3YHB6TTWDVNIHANCNFSM6AAAAAARAYLLA4 . You are receiving this because you were mentioned.Message ID: @.>

Ohh ok! just wanted to confirm. Thanks for confirming @cristianmedeiros !😊

rajat-tomar avatar Oct 17 '22 14:10 rajat-tomar

hi @rajat-tomar I probably won't finish it today to hacktoberfest, do you want to assing this issue for you?

cristianmedeiros avatar Oct 31 '22 14:10 cristianmedeiros

It's okay @cristianmedeiros, Hacktoberfest is anyways ending now. You should give it one more shot. For now, I'm working on some other priority projects. Just let me know if you need any help regarding this else I'll be happy to pick this up this weekend.

rajat-tomar avatar Oct 31 '22 15:10 rajat-tomar

this issues seems to be inactive and i'm assuming is available. will work on this now.

sbpipb avatar Jul 16 '24 10:07 sbpipb