ifme icon indicating copy to clipboard operation
ifme copied to clipboard

Add ARIA attribute to element that opens the Tooltip component

Open julianguyen opened this issue 2 years ago • 6 comments

Description

In the Tooltip component (code), the element that opens the tooltip has an aria-labelledby attribute on it so that it can be associated with the element with role="tooltip". This element that opens the tooltip does not have a role itself. This will reduce the quality of the screen-reader experience.

This is a problem because the aria-labelledby attribute cannot be used on a div with no valid role attribute.

We don't want to assign a role to this div because it could contain an element of a different role. The ideal solution would be to add aria-labelledby={tooltipId} to the child that is rendered i.e. {Utils.renderContent(element)}.


Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

julianguyen avatar Oct 01 '22 14:10 julianguyen

Hello, I would like to assign myself this issue

ghost avatar Oct 05 '22 19:10 ghost

@PaxtonDevs Added you to our org! After accepting the invitation, you should be able to assign yourself to the issue.

julianguyen avatar Oct 06 '22 01:10 julianguyen

Awesome, thank you!

ghost avatar Oct 06 '22 04:10 ghost

Hi, if there is no further activity on this I'd like to contribute?

andomain avatar Oct 26 '22 09:10 andomain

Hi, I noticed this issue is still unresolved and would like to tackle it!

I took a look at [#2156] and suggest possibly breaking this issue up into two smaller issues depending on if we want to write custom functionality for rendering HTML as a React Element or use one of the other libraries recommended by the old react-render-html maintainers.

a-camarillo avatar Jan 23 '23 06:01 a-camarillo

Is this issue still unresolved? I'd like to contribute.

reedjones avatar Nov 16 '23 19:11 reedjones