ifme icon indicating copy to clipboard operation
ifme copied to clipboard

Feat/add filter moments page

Open franpb14 opened this issue 4 years ago • 1 comments

Description

Hello! I have made a new Input type with React ("multi_select") and I have added this with some filters to the moments.

More Details

React's component: I have created it looking a little bit at the implemented inputs and without using any new library. I have also added this component to the storybook and I have also added some tests.

Backend: I have added code to existing functions and added some methods to the helper. I have tried to make the code as reusable as possible in case, at some point, you want to do the same for other sections. I have also implemented new tests.

Note: there are some of the filters that are opposite so no moment is returned. Note 2: I have corrected some messages in Spanish (my native language). Last note: This is my first pull request with real code here, there are probably many things to correct, thanks to my reviewer in advance!

Corresponding Issue

#1994

Screenshots

Here is a working video:

https://user-images.githubusercontent.com/70280187/132946184-15ebdc39-d250-4347-9940-3e10731de592.mp4

And here is a screenshot of the mobile view

Screenshot from 2021-09-11 12-49-30


Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!

franpb14 avatar Sep 11 '21 11:09 franpb14

Sorry I haven't had a chance to take a look at this! Will do soon!

julianguyen avatar Oct 01 '21 17:10 julianguyen

I'm going to finish up this PR so we can merge it! :)

julianguyen avatar Feb 19 '24 20:02 julianguyen