social-buttons icon indicating copy to clipboard operation
social-buttons copied to clipboard

Published 20 hours ago • verified publisher icon iffyuva

Twitter Widget Doesn't Work Over SSL

Open dalezak opened this issue 11 years ago • 7 comments

The Twitter widget is broken when used on website with SSL.

twitter_widget

dalezak avatar Dec 06 '13 00:12 dalezak

[blocked] The page at [website address] was loaded over HTTPS, but ran insecure content from 'http://platform.twitter.com/widgets.js': this content should also be loaded over HTTPS.

dalezak avatar Dec 06 '13 12:12 dalezak

Looks like the problem is due to hardcoded http://platform.twitter.com/widgets.js path, which should instead use the protocol of the host.

https://github.com/iffyuva/social-buttons/blob/master/lib/social_buttons/view_helpers/tweet.rb#L39

dalezak avatar Dec 06 '13 12:12 dalezak

Please fix whatever needs fixin and make a pull request :) One option is to add a configuration singleton class to be used by all the social buttons ;)

kristianmandrup avatar Dec 06 '13 13:12 kristianmandrup

Hmm, do you need to increment the version number so the gem will be updated?

dalezak avatar Dec 06 '13 14:12 dalezak

After doing bundle update, I'm still getting social-buttons 0.3.7 which still has http:// rather than https://

Any ideas?

dalezak avatar Dec 06 '13 14:12 dalezak

Just reference the repo directly from your gemfile. Yes, the version needs to be bumped and then pushed to RubyGems as a new release.

kristianmandrup avatar Dec 06 '13 15:12 kristianmandrup

Please also add my Config class to the repo and make a new pull request.

https://github.com/iffyuva/social-buttons/pull/10#issuecomment-29994914

I'm at work where I can't really do git commands :(

kristianmandrup avatar Dec 06 '13 15:12 kristianmandrup