data-confirm-modal icon indicating copy to clipboard operation
data-confirm-modal copied to clipboard

MODAL: Option "backdrop" provided type "undefined"

Open archonic opened this issue 7 years ago • 2 comments

I'm getting this with bootstrap 4:

MODAL: Option "backdrop" provided type "undefined" but expected type "(boolean|string)"

The link is just

link_to 'Cancel account', registration_path(resource_name), method: :delete, class: 'btn btn-danger', data: { confirm: 'Are you sure?' }

I'm thinking the version of BS 4 I'm running changed the argument requirements. Looking at data-confirm-modal.js, it looks like it plugs the data attributes directly into the BS modal function without conferring with defaults. Should backdrop, keyboard and show be using ||= instead?

archonic avatar Feb 09 '18 16:02 archonic

Same error here. Can I help giving you more information?

camilleroux avatar Mar 23 '18 18:03 camilleroux

Because this gem basically just wraps one JS file, I took out that file, modified it for only supporting BS4, converted it to coffee and fixed the error seen here.

Here's the gist. https://gist.github.com/archonic/8a9392a005d0bc1ab621c69619825afe

I'll leave the issue open because I think this gem is broken out of the box for bootstrap 4 post-release.

archonic avatar Mar 23 '18 18:03 archonic