chronomodel icon indicating copy to clipboard operation
chronomodel copied to clipboard

Tweak how options[:temporal] is handled

Open pnomolos opened this issue 4 years ago • 3 comments

I still need to write specs for this, but it changes how options[:temporal] is handled so that if you don't pass anything explicit it'll work fine (rather than right now, where if you don't specify temporal: true on a chronomodel-handled table it'll return it to a plain table).

pnomolos avatar Mar 04 '20 06:03 pnomolos

Looks like this project has begun to be maintained again, so I've merged upstream master. If this PR is still useful would it be possible to get it in the next release?

pnomolos avatar Nov 25 '21 06:11 pnomolos

Hi, same considerations as the other PR. Any chance to rebase instead of merge and provide a failing test case?

tagliala avatar Nov 25 '21 08:11 tagliala

@tagliala I've finally come back to this, including adding specs and reworking some functionality. I hope it's good to go now, please let me know if you'd like any further changes

pnomolos avatar Sep 12 '22 17:09 pnomolos