Eugen Stan

> > If we merge the checkstyle fixes we will get a lot of conflicts with the existing PR's. > > Anyway we will have these conflicts at one moment...

I will make some time these days to check the PR and add feedback on it.

@gilPts : Here is my feedback: The PR looks good overall. * I would add documentation for this feature in the asciidoc files + link to issue ?! * I...

@PierreSmits : True, and maybe we should consider moving those there. I don't think we will have a lot of config options use via ENV. For those that need this...

@mbrohl : ENV is opt-in. If you check the code, you will see default vaules are provided. End user does not have to do anything, but can. ``` jdbc-uri="${env:OFB_POSTGRES_DB:jdbc:postgresql://127.0.0.1/ofbiz}" jdbc-username="${env:OFB_POSTGRES_USER:ofbiz}"...

Happy new year! @mbrohl : Centralized configuration would be very nice. But I would prefer not to drag this for too long. As it is, the PR is pretty small...

Hi @JacquesLeRoux If I had access to a windows I believe I can fix this. I think it should be a gradle config change only. Can we do automated builds...

@JacquesLeRoux : I forced pushed some changes that might fix this. ``` sourceCompatibility = '1.8' targetCompatibility = '1.8' ``` was updated to ``` java { sourceCompatibility(JavaVersion.VERSION_1_8) targetCompatibility(JavaVersion.VERSION_1_8) } ``` https://docs.gradle.org/current/userguide/java_plugin.html#sec:java-extension...

@JacquesLeRoux : I just bought a Windows 10 license and I will try to build it there once I set it up.

The build work on my machine: ``` ------------------------------------------------------------ Build time: 2021-12-01 15:42:20 UTC Revision: 2c62cec93e0b15a7d2cd68746f3348796d6d42bd Kotlin: 1.5.31 Groovy: 3.0.9 Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021 JVM:...