fix: Use email or name when building community list view

[microamp]

Fixes #7036

An additional argument has been added to pass the email_or_name variable through.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.93%. Comparing base (187c2c5) to head (ff03da7). Report is 62 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7203      +/-   ##
==========================================
- Coverage   88.98%   88.93%   -0.05%     
==========================================
  Files         291      291              
  Lines       40717    41063     +346     
==========================================
+ Hits        36233    36521     +288     
- Misses       4484     4542      +58     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[rjsparks]

Since this is fixing a crash bug, we should add, or modify an existing test to include, a test that exercises the condition that led to the crash.

That test should also cover the view for person Y after having constructed a person X with name N and email E, and a person Y with name N (note same name) but no email.

[jennifer-richards]

I added a test - which fails because it turns out this goes deeper. There's a similar issue in list_menu.html with the added wrinkle that it's included both in the view we're already touching and in group_documents.html.

[microamp]

I added a test - which fails because it turns out this goes deeper. There's a similar issue in list_menu.html with the added wrinkle that it's included both in the view we're already touching and in group_documents.html.

Thanks for having a go at it! (It was on my list at the code sprint, but I ran out of time.)

I'll have a look at the files you mentioned when I can.

[rjsparks]

@jennifer-richards @microamp Is this still something to pursue?

[jennifer-richards]

@jennifer-richards @microamp Is this still something to pursue?

Yes, original bug is still there afaik and I think this was a good approach.