datatracker
datatracker copied to clipboard
fix: Show recordings for interims
List the recordings if the "meeting numnber" starts with "interim"
Fixes: #6543
Should the same fix be made for the buttons, at https://github.com/ietf-tools/datatracker/blob/main/ietf/templates/meeting/session_buttons_include.html#L139 ?
Codecov Report
Attention: Patch coverage is 85.71429%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 88.77%. Comparing base (
c7f6bde
) to head (9c1dd11
). Report is 30 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
ietf/meeting/models.py | 78.57% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #7197 +/- ##
==========================================
- Coverage 88.78% 88.77% -0.02%
==========================================
Files 296 299 +3
Lines 41320 41355 +35
==========================================
+ Hits 36687 36712 +25
- Misses 4633 4643 +10
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Should the same fix be made for the buttons, at https://github.com/ietf-tools/datatracker/blob/main/ietf/templates/meeting/session_buttons_include.html#L139 ?
Looks like it.
This really needs a new (or updated) test.
Rebased, squashed, fixed the tests. This is ready for review now.
@jennifer-richards I believe I addressed all your feedback, PTAL.
I think there was still disagreement about useNotes
vs usesNotes
. Easier to push a commit than to point at them, but please review that I'm not mixing up similarly named variables in 4e8ce54cdbaeb35c77c370ba86e90a29ab629376
I need some time. I lost my phone. I am need to recover information how check my activity
On Wed, Aug 7, 2024, 9:43 PM Robert Sparks @.***> wrote:
@.**** approved this pull request.
— Reply to this email directly, view it on GitHub https://github.com/ietf-tools/datatracker/pull/7197#pullrequestreview-2225571227, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJFWHDWYP25WRF6ERBDYFELZQI6B5AVCNFSM6AAAAABEZAUU42VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRVGU3TCMRSG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>