datatracker
datatracker copied to clipboard
fix: Raise 404 when multiple person found in /community/personal/
Codecov Report
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
4c396e6
) 88.97% compared to head (051022d
) 88.98%. Report is 22 commits behind head on main.
:exclamation: Current head 051022d differs from pull request most recent head ebc0f61. Consider uploading reports for the commit ebc0f61 to get more accurate results
Files | Patch % | Lines |
---|---|---|
ietf/community/views.py | 25.00% | 6 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #7038 +/- ##
=======================================
Coverage 88.97% 88.98%
=======================================
Files 291 291
Lines 40717 40717
=======================================
+ Hits 36229 36233 +4
+ Misses 4488 4484 -4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Would it make sense to push the
MultiplePersonError
-> 404 logic down intolookup_community_list()
? Is it used anywhere that a 404 isn't the right thing to do?(I'm not actually a fan of helper directly 404ing, but that's a bigger set of changes...)
Yes, I think this would make sense, and it would obviate the need for the MultiplePerssonError exception in the first place - the utility could simply raise the 404 instead.
@kesara @jennifer-richards : Is this still something we wish to pursue?
@kesara @jennifer-richards : Is this still something we wish to pursue?
I think so, though I don't recall in detail the circumstances leading to it. I guess it's replacing 500s with 404s?
[edit] or I guess 300s with 404s, based on the test changes